[ovs-dev] [PATCH 6/8] gre: Add functions to determine address type to compat layer.

Jesse Gross jesse at nicira.com
Thu Mar 4 22:20:25 UTC 2010


On Thu, Mar 4, 2010 at 5:03 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Thu, Mar 04, 2010 at 01:22:11PM -0500, Jesse Gross wrote:
> > --- a/datapath/linux-2.6/compat-2.6/include/linux/in.h
> > +++ b/datapath/linux-2.6/compat-2.6/include/linux/in.h
> > @@ -5,11 +5,40 @@
> >
> >  #ifndef HAVE_IPV4_IS_MULTICAST
> >
> > +#ifndef INADDR_BROADCAST
> > +#define INADDR_BROADCAST        ((unsigned long int) 0xffffffff)
> > +#endif
>
> Did INADDR_BROADCAST sneak in there by mistake?  My kernel archaeology
> shows that INADDR_BROADCAST was in 2.6.12, so I don't think we are at
> any risk of needing to define it ourselves.
>

I vaguely remember intentionally adding it but you are right, it's been
there for a long time so I don't know what I was thinking.


>
> The rest looks fine.  Optionally you could leave out the "#if
> __KERNEL__" conditional, since we only use this from kernel code, but it
> won't hurt either way.
>

Hmm, I think I was asleep when I was adding stuff to this file.  I took this
out too.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100304/d76d8d89/attachment-0003.html>


More information about the dev mailing list