[ovs-dev] [PATCH 3/3] datapath: Consistently maintain flow key.
Jesse Gross
jesse at nicira.com
Mon Mar 15 19:50:53 UTC 2010
On Fri, Mar 12, 2010 at 6:03 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Mar 12, 2010 at 04:57:04PM -0500, Jesse Gross wrote:
> > After executing an action that changes a packet sometimes we update
> > the flow key and sometimes we don't. This is potentially problematic
> > because we sometimes use the key for checks later on. This consistently
> > maintains the key.
>
> My goal here was to bother updating only the flow key fields that we
> ever refer to afterward in checks. Maybe this is too error-prone and
> hard to maintain; if you think so (or if I actually goofed already) then
> feel free to push out this patch.
>
I figured that was the goal. I don't think that there is anywhere where the
key is read but not updated but there are places where it is updated but
never read. I think it's nicer to be consistent plus I plan to use the flow
key more in the future, so I just wanted to keep the key up to date at all
times.
I pushed this and the other patches in the series.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100315/fa248031/attachment-0003.html>
More information about the dev
mailing list