[ovs-dev] [PATCH 4/8] ovsdb: Introduce for_each_txn_row() iterator function for transactions.

Jesse Gross jesse at nicira.com
Wed Mar 17 18:02:24 UTC 2010


On Mon, Mar 15, 2010 at 6:42 PM, Ben Pfaff <blp at nicira.com> wrote:
>
> +
> +/* Used by for_each_txn_row() to track tables and rows that have been
> + * processed.  */
> +static unsigned int serial;
>

This static variable and the new members in the two structs that are used
for iteration feel a little weird to me.  I don't think that it will cause a
problem since this is all single threaded code but it still doesn't really
seem right.  I don't know this code well enough to say what might be right
though.


> +/* Calls 'cb' for every txn_row within 'txn'.  If 'cb' returns nonnull,
> this
> + * abort the iteration and for_each_txn_row() passes the error up.
>  Otherwise,
> + * returns a null pointer after iteration is complete.
>

"abort" should be "aborts"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100317/bd9f63ba/attachment-0003.html>


More information about the dev mailing list