[ovs-dev] [PATCH 8/8] vswitch: Use weak references in Mirror table.

Jesse Gross jesse at nicira.com
Wed Mar 17 18:04:25 UTC 2010


On Mon, Mar 15, 2010 at 6:42 PM, Ben Pfaff <blp at nicira.com> wrote:

> A port mirror seems sufficiently disconnected from the ports that it
> mirrors that it seems counterproductive to forbid removing a port if
> it is mirrored.  This commit therefore changes the references from
> Mirror to Port from strong references to weak references, so that
> removing a port automatically removes references to it from the Mirror
> table.
>
> Since this could cause the port and VLAN selection for the Mirror to
> become empty, which would make the mirror select all packets, at the same
> time this commit adds a new column "select_all" to Mirror, to explicitly
> allow selecting all packets.
>

I think is more logical behavior in any case, independent of the addition of
weak references.  The rest of this set looks reasonable to me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100317/a60eae0a/attachment-0003.html>


More information about the dev mailing list