[ovs-dev] fd leak in get_major()

Jesse Gross jesse at nicira.com
Thu Mar 25 15:26:28 UTC 2010


On Thu, Mar 25, 2010 at 1:57 AM, Tetsuo NAKAGAWA <nakagawa at mxc.nes.nec.co.jp
> wrote:

> Hi.
>
> I was reading source code of Open vSwitch, and found
> following defect.
>
>  diff -ru ./openvswitch-master-20100325.org/lib/dpif-linux.c./openvswitch-master-20100325/lib/dpif-linux.c
>  --- ./openvswitch-master-20100325.org/lib/dpif-linux.c  2010-03-25
> 08:56:28.000000000 +0900
>  +++ ./openvswitch-master-20100325/lib/dpif-linux.c      2010-03-25
> 14:45:20.000000000 +0900
>  @@ -677,6 +677,8 @@
>           }
>       }
>
>  +    fclose(file);
>  +
>       VLOG_ERR("%s: %s major not found (is the module loaded?)", fn,
> target);
>       return -ENODEV;
>   }
>
> There is also same defect in openflow-1.0 branch.
>

Thank you, I pushed your fix to master and openflow-1.0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100325/d2efd94c/attachment-0003.html>


More information about the dev mailing list