[ovs-dev] [PATCH] timeval: Always log true poll interval instead of rounding off.
Ben Pfaff
blp at nicira.com
Thu Mar 25 19:08:11 UTC 2010
Thanks, I pushed this out.
On Thu, Mar 25, 2010 at 12:04:15PM -0700, Justin Pettit wrote:
> Looks good to me.
>
> --Justin
>
>
> On Mar 25, 2010, at 11:34 AM, Ben Pfaff wrote:
>
> > This code triggers when a trip through the process's main loop takes much
> > longer than expected. The code for calculating the expected time rounds
> > down to a maximum of 10000 ms to avoid overflow. But there is no reason
> > that the correct time should not be displayed in the log message, and
> > furthermore displaying the correct time may help tracking down the
> > underlying issue, since it lets the administrator find out exactly when
> > the trip through the main loop started. So this commit displays the exact
> > time without rounding down.
> > ---
> > lib/timeval.c | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/timeval.c b/lib/timeval.c
> > index 5e42387..ab564a1 100644
> > --- a/lib/timeval.c
> > +++ b/lib/timeval.c
> > @@ -1,5 +1,5 @@
> > /*
> > - * Copyright (c) 2008, 2009, 2010 Nicira Networks.
> > + * Copyright (c) 2008, 2009, 2010 Nicira Networks.
> > *
> > * Licensed under the Apache License, Version 2.0 (the "License");
> > * you may not use this file except in compliance with the License.
> > @@ -317,10 +317,10 @@ log_poll_interval(long long int last_wakeup, const struct rusage *last_rusage)
> > struct rusage rusage;
> >
> > getrusage(RUSAGE_SELF, &rusage);
> > - VLOG_WARN("%u ms poll interval (%lld ms user, %lld ms system) "
> > + VLOG_WARN("%lld ms poll interval (%lld ms user, %lld ms system) "
> > "is over %u times the weighted mean interval %u ms "
> > "(%u samples)",
> > - (interval + 8) / 16,
> > + now - last_wakeup,
> > timeval_diff_msec(&rusage.ru_utime, &last_rusage->ru_utime),
> > timeval_diff_msec(&rusage.ru_stime, &last_rusage->ru_stime),
> > interval / mean_interval,
> > --
> > 1.6.6.1
> >
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
>
More information about the dev
mailing list