[ovs-dev] [PATCH] Cleanup default file locations and XenServer packaging
Justin Pettit
jpettit at nicira.com
Fri Mar 26 21:42:32 UTC 2010
On Mar 26, 2010, at 12:33 PM, Ben Pfaff wrote:
> Justin Pettit's time warp struck again on Thu, Mar 25, 2010 at
> 11:27:03PM -0700:
>> This commit cleans up the locations of a number of files and directories
>> used. These include:
>>
>> - Config file lives in /etc/openvswitch/conf.db
>
> I see one reference to vswitch.db instead of conf.db, in
> debian/openvswitch-switch.init. I guess that is a typo.
>
>> - Logs go into /var/log/openvswitch
>> - ovsdb-server socket is /var/run/openvswitch/db.sock
>
> Justin told me out-of-band that he missed some of the db.sock changes,
> so I'm ignoring those.
>
>> - Schema goes into /usr/share/openvswitch/vswitch.ovsschema
>> - PID files go in /var/run/openvswitch
>
> The only other comment I have is that the mkdir commands should probably
> give an explicit mode for the new directory, probably 0755. It might
> even be best to use "install -d -m 755 -o root -g root" just to be
> super-sure about the directory's owner and group and permissions.
Thanks. I incorporated your suggestions and pushed.
--Justin
More information about the dev
mailing list