[ovs-dev] [PATCH] openvswitch-cfg-update: Fix "set-ssl" command arguments.

Ben Pfaff blp at nicira.com
Tue Mar 30 21:15:53 UTC 2010


Thanks.

I added a comment.

On Tue, Mar 30, 2010 at 02:07:52PM -0700, Justin Pettit wrote:
> Looks good.  It may be useful to add a comment about this, since I
> could see someone knocking it out again when working in that area.
> 
> --Justin
> 
> 
> On Mar 30, 2010, at 9:02 AM, Ben Pfaff wrote:
> 
> > The SSL certificate and the private key are both in
> > /etc/xensource/xapi-ssl.pem, so it must be mentioned twice in the set-ssl
> > command invocation.
> > 
> > Bug accidentally introduced in commit bc391960 "Cleanup default file
> > locations and XenServer packaging".
> > 
> > Reported-by: Peter Balland <peter at nicira.com>
> > Tested-by: Peter Balland <peter at nicira.com>
> > ---
> > .../etc_xapi.d_plugins_openvswitch-cfg-update      |    1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/xenserver/etc_xapi.d_plugins_openvswitch-cfg-update b/xenserver/etc_xapi.d_plugins_openvswitch-cfg-update
> > index 8314a1b..b573b03 100755
> > --- a/xenserver/etc_xapi.d_plugins_openvswitch-cfg-update
> > +++ b/xenserver/etc_xapi.d_plugins_openvswitch-cfg-update
> > @@ -80,6 +80,7 @@ def setControllerCfg(controller):
> >                    "--", "del-ssl",
> >                    "--", "--bootstrap", "set-ssl",
> >                    "/etc/xensource/xapi-ssl.pem",
> > +                   "/etc/xensource/xapi-ssl.pem",
> >                    cacert_filename,
> >                    "--", "set", "Open_vSwitch", ".",
> >                    'managers="ssl:' + controller + ':6632"'])
> > -- 
> > 1.6.6.1
> > 
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
> 




More information about the dev mailing list