[ovs-dev] [PATCH] datapath: Don't hold dp_mutex when setting internal devs MTU.

Ben Pfaff blp at nicira.com
Sat May 1 00:01:28 UTC 2010


On Mon, Apr 26, 2010 at 06:30:03PM -0700, Jesse Gross wrote:
> We currently acquire dp_mutex when we are notified that the MTU
> of a device attached to the datapath has changed so that we can
> set the internal devices to the minimum MTU.  However, it is not
> required to hold dp_mutex because we already have RTNL lock and it
> causes a deadlock, so don't do it.

I don't see a problem with this patch.

But I don't see the deadlock, either.  dp->mutex nests inside
rtnl_lock, and I don't any inversion of that order being fixed here.

I don't know why the (!(port.flags & ODP_PORT_INTERNAL)) test was
dropped in attach_port().




More information about the dev mailing list