[ovs-dev] [Scalability 02/10] bridge: Optimize iface_lookup() and port_lookup_iface() with a hash.

Jesse Gross jesse at nicira.com
Wed May 5 20:57:29 UTC 2010


On Mon, May 3, 2010 at 3:50 PM, Ben Pfaff <blp at nicira.com> wrote:

>  void
> +shash_add_assert(struct shash *sh, const char *name, const void *data)
> +{
> +    bool added OVS_UNUSED = shash_add_once(sh, name, data);
> +    assert(added);
> +}
>

How come "added" is marked as unused?


>     /* Check and delete duplicate interfaces. */
> -    svec_init(&ifaces);
> -    iterate_and_prune_ifaces(br, check_duplicate_ifaces, &ifaces);
> -    svec_destroy(&ifaces);
> +    //svec_init(&ifaces);
> +    //iterate_and_prune_ifaces(br, check_duplicate_ifaces, &ifaces);
> +    //svec_destroy(&ifaces);
>

I think we can just dump these lines.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100505/3f867d80/attachment-0003.html>


More information about the dev mailing list