[ovs-dev] [Scalability 10/10] netdev-linux: Optimize removing policing from an interface.

[Ben Pfaff]

On Wed, May 05, 2010 at 01:57:44PM -0700, Jesse Gross wrote:
> On Mon, May 3, 2010 at 3:51 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > +    ofpbuf_init(&request, 0);
> > +    nl_msg_put_nlmsghdr(&request, rtnl_sock, sizeof *tcmsg,
> > +                        RTM_DELQDISC, NLM_F_REQUEST);
> > +    tcmsg = ofpbuf_put_zeros(&request, sizeof *tcmsg);
> > +    tcmsg->tcm_family = AF_UNSPEC;
> > +    tcmsg->tcm_ifindex = ifindex;
> > +    tcmsg->tcm_handle = 0xffff0000;
> > +    tcmsg->tcm_parent = TC_H_INGRESS;
> > +    nl_msg_put_string(&request, TCA_KIND, "ingress");
> > +    nl_msg_put_unspec(&request, TCA_OPTIONS, NULL, 0);
> > +    error = nl_sock_transact(rtnl_sock, &request, &reply);
> > +    ofpbuf_uninit(&request);
> > +    ofpbuf_delete(reply);
> 
> I'm going to trust that the Netlink stuff is right...

I tested that it successfully removed policing from an interface, so I
think it's OK.

> The rest of this set looks good.

Thanks.  I'm going to do a little more testing and then push it out.