[ovs-dev] [PATCH] flow: Zero wildcarded fields in flow_from_match().

[Jesse Gross]

On Mon, May 10, 2010 at 2:28 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Fri, May 07, 2010 at 04:07:39PM -0700, Jesse Gross wrote:
> > If a field is wildcarded in struct ofp_match then rather than copy
> > over the value, just zero it out.  This is particularly important
> > with the tun_id field which is overloaded onto the cookie but it
> > is also generally nicer to have a canonicalized form.
>
> The existing normalize_match() function is supposed to do this same
> transformation in-place on a "struct ofp_match".  Is it buggy, or are we
> not calling it on some path?
>

Oops, I completely forgot about that.  This came up in regard to new tun_id
field, which obviously isn't covered by normalize_match() since it isn't
part of struct ofp_match.  I'll send out another patch that just does
tun_id.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100510/490cbfe9/attachment-0003.html>