[ovs-dev] [PATCH 3/3] datapath: Add 32-bit compatibility ioctls.

Ben Pfaff blp at nicira.com
Thu May 13 22:29:10 UTC 2010


On Thu, May 13, 2010 at 03:26:19PM -0700, Jesse Gross wrote:
> On Thu, May 13, 2010 at 2:46 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Wed, May 12, 2010 at 05:38:40PM -0700, Jesse Gross wrote:
> > > On Mon, May 10, 2010 at 2:13 PM, Ben Pfaff <blp at nicira.com> wrote:
> > > It probably also should have a ODP_PORT_DETACH32 defined for it.
> >
> > It would be defined as:
> >        #define ODP_PORT_DETACH32       _IOR('O', 8, int)
> > which is the same as ODP_PORT_DETACH, since 'int' has the same size on
> > 32- and 64-bit architectures.  So I don't see the need.
> 
> Oops, you're right.
> 
> All the changes that you posted for this series look good to me.  Thanks for
> dealing with all the compatibility stuff.

Thanks for the reviews.

On the assumption that we don't care to switch *exclusively* to sparc64,
I will now lightly test this tree on x86, and then push it out.




More information about the dev mailing list