[ovs-dev] [PATCH 3/3] netdev: do not assign dev->br_port when attach/detach vport

[Wei Yongjun]

assign dev->br_port pointer will cause panic if kernel bridge
module is loaded and the network interface is down. In fact,
assign the dev->br_port is useless, so just remove them to
avoid oops.

Signed-off-by: Wei Yongjun <yjwei at cn.fujitsu.com>
---
 datapath/vport-netdev.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c
index 826b614..f44b8d8 100644
--- a/datapath/vport-netdev.c
+++ b/datapath/vport-netdev.c
@@ -192,7 +192,6 @@ netdev_attach(struct vport *vport)
 
 	dev_set_promiscuity(netdev_vport->dev, 1);
 	dev_disable_lro(netdev_vport->dev);
-	rcu_assign_pointer(netdev_vport->dev->br_port, (struct net_bridge_port *)vport);
 
 	return 0;
 }
@@ -202,7 +201,6 @@ netdev_detach(struct vport *vport)
 {
 	struct netdev_vport *netdev_vport = netdev_vport_priv(vport);
 
-	rcu_assign_pointer(netdev_vport->dev->br_port, NULL);
 	dev_set_promiscuity(netdev_vport->dev, -1);
 
 	return 0;
-- 
1.6.5.2