[ovs-dev] [PATCH] datapath: Fix XFLOW_PORT_GROUP_GET implementation.

Jesse Gross jesse at nicira.com
Mon May 24 20:50:50 UTC 2010


On Mon, May 24, 2010 at 11:27 AM, Ben Pfaff <blp at nicira.com> wrote:

> The final argument to do_get_port_group() is supposed to be a user pointer
> to the number of ports, to be updated with put_user(), but it was actually
> a kernel pointer, so "ovs-dpctl dump-groups" and anything else that used
> this ioctl would always fail with -EFAULT.  This commit fixes it.
>
> Bug introduced in commit 44e05eca "datapath: Prepare to support 32-bit
> compatibility ioctls" for normal ioctls and for compat ioctls at their
> introduction in commit 3fbd517acf"datapath: Add 32-bit compatibility
> ioctls."
>

This looks good.  The title kind of threw me off though, because I thought
that it was specific to the wdp branch at first.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20100524/4472d23c/attachment-0003.html>


More information about the dev mailing list