[ovs-dev] [FreeBSD 9/9] vswitchd: Build ovs-brcompatd only on Linux systems.

Justin Pettit jpettit at nicira.com
Wed May 26 22:42:50 UTC 2010


On May 26, 2010, at 3:36 PM, Ben Pfaff wrote:

> On Wed, May 26, 2010 at 03:32:57PM -0700, Justin Pettit wrote:
>> On May 26, 2010, at 10:40 AM, Ben Pfaff wrote:
>> 
>>> +if HAVE_NETLINK
>>> +sbin_PROGRAMS += vswitchd/ovs-brcompatd
>>> vswitchd_ovs_brcompatd_SOURCES = \
>>> 	vswitchd/ovs-brcompatd.c \
>>> 	vswitchd/vswitch-idl.c \
>>> 	vswitchd/vswitch-idl.h
>>> -
>>> vswitchd_ovs_brcompatd_LDADD = lib/libopenvswitch.a $(SSL_LIBS)
>>> -
>>> -EXTRA_DIST += \
>>> -	vswitchd/ovs-vswitchd.8.in \
>>> -	vswitchd/ovs-brcompatd.8.in
>>> +endif
>>> +EXTRA_DIST += vswitchd/ovs-brcompatd.8.in
>> 
>> Shouldn't that endif be placed after the EXTRA_DIST?
> 
> That would bust the distribution, unfortunately:
>        http://www.mail-archive.com/automake@gnu.org/msg15246.html


Is there a reason you broke EXTRA_DIST into two parts then?  In it's current form, it would probably be a good idea to put a comment in there describing it, because I imagine many people will be tempted to move that into the endif.

--Justin






More information about the dev mailing list