[ovs-dev] [PATCH 1/2] ofproto: Fix treatment of out-of-band controllers.
Justin Pettit
jpettit at nicira.com
Thu May 27 07:32:06 UTC 2010
Looks good to me. It sounds like the commit message can be updated with Jan's name.
--Justin
On May 26, 2010, at 1:39 PM, Ben Pfaff wrote:
> This code was treated every controller as in-band, but obviously that's not
> correct.
>
> Reported by partner.
> ---
> ofproto/ofproto.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index 1010948..7b8effd 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -545,6 +545,10 @@ update_in_band_remotes(struct ofproto *ofproto)
> HMAP_FOR_EACH (ofconn, struct ofconn, hmap_node, &ofproto->controllers) {
> struct sockaddr_in *sin = &addrs[n_addrs];
>
> + if (ofconn->band == OFPROTO_OUT_OF_BAND) {
> + continue;
> + }
> +
> sin->sin_addr.s_addr = rconn_get_remote_ip(ofconn->rconn);
> if (sin->sin_addr.s_addr) {
> sin->sin_port = rconn_get_remote_port(ofconn->rconn);
> --
> 1.7.1
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
More information about the dev
mailing list