[ovs-dev] [PATCH 1/2] autoconf: Don't die on grep error.
blp at nicira.com
Wed Nov 3 00:05:20 UTC 2010
On Tue, Nov 02, 2010 at 04:53:09PM -0700, Jesse Gross wrote:
> The most likely cause of an error when grepping for a compatibility
> string is that the file doesn't exist. Since this can be a valid
> result when files are added in later versions, we shouldn't kill
> the build. Instead, note that the file doesn't exist but otherwise
> treat it as if the string was not found.
It's good to tolerate a missing file, but wouldn't it be better to do so
by checking for it beforehand with "test -r", instead of assuming that
any error from "grep" means a missing file?
More information about the dev