[ovs-dev] [PATCH] datapath: Directly use free_netdev for internal devices.

Jesse Gross jesse at nicira.com
Fri Nov 5 00:35:29 UTC 2010


On Thu, Nov 4, 2010 at 4:51 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Thu, Nov 04, 2010 at 04:38:31PM -0700, Jesse Gross wrote:
>> Currently internal devices register a destructor function which
>> simply calls free_netdev.  Instead we can simply set the destructor
>> to free_netdev.  In addition to being cleaner, it is also a bug fix
>> because the module could be unloaded before the destructor is called,
>> making a call into our code illegal.
>>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> Good catch.
>
> I checked that free_netdev() was declared the same way back to 2.6.15.
> It was.
>
> Acked-by: Ben Pfaff <blp at nicira.com>

Thanks, I pushed this.




More information about the dev mailing list