[ovs-dev] [PATCH] print the IP TOS for flows with any IP network types

Romain Lenglet romain.lenglet at berabera.info
Fri Nov 5 01:52:16 UTC 2010

On 11/5/10 10:23, Jesse Gross wrote:
> On Thu, Nov 4, 2010 at 5:30 PM,<romain.lenglet at berabera.info>  wrote:
>> From: Romain Lenglet<romain.lenglet at berabera.info>
>> Print the NW_TOS field for all flows matching the IP Ethernet packet
>> type, for all NW_PROTO types.
> One minor thing: normally the subject line of the commit starts with
> the general area that it affects, followed by a colon, followed by the
> description starting with a capital letter.

Done. I just didn't know what area was covering this file, so I had left 
it out...

>> +    if (!skip_tos) {
>> +        print_wild(&f, "nw_tos=", w&  OFPFW_NW_TOS, verbosity,
>> +                   "%u", om->nw_tos);
>> +    }
> I think you should be able to accomplish this without using the
> skip_tos flag.  If the ToS isn't applicable (because the protocol
> isn't IP) then it will be wildcarded.  print_wild() doesn't print
> wildcarded fields, unless the verbosity is high.

Right. I wasn't sure if flows were normalized at this level or not.

> The skip_XXX fields are just used if the protocol combination has a
> short form such as "tcp", in which case the fields which represent TCP
> are left out.  However, in this case the ToS is never part of a short
> form and should always be printed if applicable.


Thanks for your quick review and your comments.
I sent the updated patch separately.
Romain Lenglet

More information about the dev mailing list