[ovs-dev] [manager-options 5/5] Add "Manager" and "manager_options" to allow options for OVSDB connections.

[Ben Pfaff]

On Thu, Nov 04, 2010 at 05:18:05PM -0700, Ethan Jackson wrote:
> > +void
> > +jsonrpc_session_set_max_backoff(struct jsonrpc_session *s, int max_backoff)
> > +{
> > +    reconnect_set_backoff(s->reconnect, 1000, max_backoff)
> > +}
> Seems like we should pass 0 instead of 1000 for the min_backoff so
> that the reconnect code can choose an appropriate default.

Fair enough, changed.

> > diff --git a/ovsdb/ovsdb-server.1.in b/ovsdb/ovsdb-server.1.in
> > index d7beba7..6d68600 100644
> > --- a/ovsdb/ovsdb-server.1.in
> > +++ b/ovsdb/ovsdb-server.1.in
> > @@ -41,11 +41,31 @@ Adds \fIremote\fR as a connection method used by \fBovsdb\-server\fR.
> >  .
> >  .IP "\fBdb:\fItable\fB,\fIcolumn\fR"
> >  Reads additional connection methods from \fIcolumn\fR in all of the
> > -rows in \fItable\fR within the \fBovsdb\-server\fR database.  The
> 
> This first sentence is pretty confusing.

OK, I deleted the "within the \fBovsdb\-server\fR database" part.  Now
the sentence is shorter, anyhow, and one hopes that the reader would
guess that the ovsdb-server database is what is meant.

Thank you for the reviews.