[ovs-dev] [nxm 28/42] ofproto: Generalize reject_slave_controller().

Ben Pfaff blp at nicira.com
Fri Nov 5 19:47:45 UTC 2010


On Fri, Nov 05, 2010 at 11:37:23AM -0700, Justin Pettit wrote:
> On Oct 28, 2010, at 10:27 AM, Ben Pfaff wrote:
> 
> > static int
> > -reject_slave_controller(struct ofconn *ofconn, const struct ofp_header *oh)
> > +reject_slave_controller(struct ofconn *ofconn, const const char *msg_type)
> 
> I assume that you didn't mean for that to be a "const const".  Is "msg_type" *really* constant?  "I said const, mother f'er!"

Odd, that one was already fixed in my local tree, but I don't remember
changing it.

Thanks for the review.




More information about the dev mailing list