[ovs-dev] [nxm 31/42] ofproto: Change ofproto_add_flow(), ofproto_delete_flow() to take cls_rule.

Justin Pettit jpettit at nicira.com
Sat Nov 6 07:52:57 UTC 2010


On Oct 28, 2010, at 10:28 AM, Ben Pfaff wrote:

> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index ccc4e32..a1ca841 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> ...
> @@ -1770,14 +1771,14 @@ bridge_reconfigure_remotes(struct bridge *br,
>     if (!n_controllers
>         && ofproto_get_fail_mode(br->ofproto) == OFPROTO_FAIL_STANDALONE) {
>         union ofp_action action;
> -        struct flow flow;
> +        struct cls_rule rule;

The fact that "rule" is used in some files to mean classifier's "struct cls_rule" and ofproto's "struct rule" elsewhere is confusing.  It would be nice at some point to disambiguate both the variable and structure names consistently.  Maybe "cls_rule" and "ofp_rule" or something.

Now that I got that off my chest, the patch looks good.

--Justin






More information about the dev mailing list