[ovs-dev] [nxm 31/42] ofproto: Change ofproto_add_flow(), ofproto_delete_flow() to take cls_rule.
Justin Pettit
jpettit at nicira.com
Sat Nov 6 08:07:38 UTC 2010
Oh, one other thing...
> static void
> -drop_rule(struct in_band *ib, const struct in_band_rule *rule)
> +drop_rule(struct in_band *ib, const struct cls_rule *rule)
> {
> - ofproto_delete_flow(ib->ofproto, &rule->flow,
> - rule->wildcards, rule->priority);
> + ofproto_delete_flow(ib->ofproto, rule);
Shouldn't flow_wildcards_init() be called before this to reset the wildcards and masks? This seems like it could be particularly problematic when an IP address is set.
> @@ -670,8 +654,7 @@ add_rule(struct in_band *ib, const struct in_band_rule *rule)
> action.output.len = htons(sizeof action);
> action.output.port = htons(OFPP_NORMAL);
> action.output.max_len = htons(0);
> - ofproto_add_flow(ib->ofproto, &rule->flow, rule->wildcards,
> - rule->priority, &action, 1, 0);
> + ofproto_add_flow(ib->ofproto, rule, &action, 1, 0);
Same here.
--Justin
More information about the dev
mailing list