[ovs-dev] [nxm 31/42] ofproto: Change ofproto_add_flow(), ofproto_delete_flow() to take cls_rule.

Ben Pfaff blp at nicira.com
Mon Nov 8 18:23:56 UTC 2010


On Sat, Nov 06, 2010 at 01:07:38AM -0700, Justin Pettit wrote:
> Oh, one other thing...
> 
> > static void
> > -drop_rule(struct in_band *ib, const struct in_band_rule *rule)
> > +drop_rule(struct in_band *ib, const struct cls_rule *rule)
> > {
> > -    ofproto_delete_flow(ib->ofproto, &rule->flow,
> > -                        rule->wildcards, rule->priority);
> > +    ofproto_delete_flow(ib->ofproto, rule);
> 
> Shouldn't flow_wildcards_init() be called before this to reset the
> wildcards and masks?  This seems like it could be particularly
> problematic when an IP address is set.

I don't understand why.  The caller already set up the rule it wanted
and passed it in as 'rule'.  Why would drop_rule() or add_rule() want to
mess with it?




More information about the dev mailing list