[ovs-dev] [nxm 37/42] ofproto: Refactor handle_packet_out().

Ben Pfaff blp at nicira.com
Wed Nov 10 01:10:25 UTC 2010


On Tue, Nov 09, 2010 at 02:39:49PM -0800, Justin Pettit wrote:
> On Oct 28, 2010, at 10:28 AM, Ben Pfaff wrote:
> 
> > @@ -2889,24 +2889,37 @@ handle_packet_out(struct ofproto *p, struct ofconn *ofconn,
> > {
> > ...
> >     error = reject_slave_controller(ofconn, "OFPT_PACKET_OUT");
> >     if (error) {
> >         return error;
> >     }
> 
> This isn't related to this patch, but it seems like it would be useful
> for debugging to have a coverage counter for rejected slave controller
> requests.

The original purpose of coverage counters was to cheaply record events
that could cause performance problems if they happened often enough.
The purpose has drifted a bit, but I think that in this case the log
message at WARN level when a slave controller modification is rejected
should be adequate to diagnose the problem.




More information about the dev mailing list