[ovs-dev] [PATCH] ofproto: Fix use of uninitialized variable.

Ben Pfaff blp at nicira.com
Wed Nov 10 23:12:42 UTC 2010


My compiler didn't report this but Ethan's did.

Reported-by: Ethan Jackson <ethan at nicira.com>
---
 ofproto/ofproto.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index e11b15d..e710c3d 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -3676,7 +3676,7 @@ handle_vendor_stats_request(struct ofconn *ofconn,
         return ofp_mkerr(OFPET_BAD_REQUEST, OFPBRC_BAD_VENDOR);
     }
 
-    if (ntohs(nsm->header.length) < sizeof(struct nicira_stats_msg)) {
+    if (ntohs(osr->header.length) < sizeof(struct nicira_stats_msg)) {
         VLOG_WARN_RL(&rl, "truncated Nicira stats request");
         return ofp_mkerr(OFPET_BAD_REQUEST, OFPBRC_BAD_LEN);
     }
-- 
1.7.1





More information about the dev mailing list