[ovs-dev] [nxm 42/42] ofp-parse: Generalize parse_ofp_add_flow_str() into parse_ofp_flow_mod().

[Justin Pettit]

On Oct 28, 2010, at 10:28 AM, Ben Pfaff wrote:

> -/* Parses 'string' as a OFPT_FLOW_MOD with subtype OFPFC_ADD and returns an
> - * ofpbuf that contains it. */
> +/* Parses 'string' as a OFPT_FLOW_MOD with command 'command' (one of OFPFC_*)
> + * and returns an ofpbuf that contains it. */

"as a" -> "as an".

> struct ofpbuf *
> -parse_ofp_add_flow_str(char *string)
> +parse_ofp_flow_mod(char *string, uint16_t command)

For consistency sake with the other external functions, this one should probably end in "_str".

Wow.  That was a depressing end to this patch review train.

Thanks for putting together this epic set of changes!

--Justin