[ovs-dev] [PATCH] system-stats: Add the Open vSwitch version to system stats in database.

[Justin Pettit]

On Nov 11, 2010, at 10:36 AM, Jesse Gross wrote:

> On Wed, Nov 10, 2010 at 10:58 PM, Justin Pettit <jpettit at nicira.com> wrote:
>> The implementation looks fine.  We already have similar information in the "external_ids" column of the "Open_vSwitch" table.  Is there a reason not to put it there?  This doesn't really feel like statistics information to me, and seems to fit better alongside the "system-type" and "system-version" keys we've already defined.
> 
> I'm not sure that it fits any better in external_ids.  Really, I think
> these general purpose columns like external_ids, other_config,
> options, etc. only make sense in situations where the type and/or
> number of the fields depend on some runtime factor (i.e. hypervisor,
> type of device,...).  If we start putting lots of things in these
> fields, we essentially no longer have a schema, just a key-value map.
> I don't think that switch version or any of the other fields mentioned
> fall into this category, so I would expect them to be first class
> fields.

I don't disagree with anything you said.  I'd just prefer not to have this information spread across a number of different places.

--Justin