[ovs-dev] [tests+nxm-ofctl 02/42] dpif-netdev: Do not log error for EOPNOTSUPP return from netdev_recv().

Justin Pettit jpettit at nicira.com
Tue Nov 23 22:59:12 UTC 2010


Looks good.

--Justin


On Nov 23, 2010, at 2:43 PM, Ben Pfaff wrote:

> If a network device does not implement receiving packets, there is no point
> in logging it as an error.
> ---
> lib/dpif-netdev.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index b4d3b53..c2e8101 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
> @@ -932,7 +932,7 @@ dp_netdev_run(void)
>             error = netdev_recv(port->netdev, &packet);
>             if (!error) {
>                 dp_netdev_port_input(dp, port, &packet);
> -            } else if (error != EAGAIN) {
> +            } else if (error != EAGAIN && error != EOPNOTSUPP) {
>                 struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
>                 VLOG_ERR_RL(&rl, "error receiving data from %s: %s",
>                             netdev_get_name(port->netdev), strerror(error));
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list