[ovs-dev] [tests+nxm-ofctl 04/42] Make installation directories overridable at runtime.
Justin Pettit
jpettit at nicira.com
Thu Nov 25 01:13:11 UTC 2010
On Nov 23, 2010, at 2:43 PM, Ben Pfaff wrote:
> --- /dev/null
> +++ b/lib/dirs.c.in
> @@ -0,0 +1,66 @@
> +#line 2 "@srcdir@/lib/dirs.c.in"
What does that "#line 2" line do?
> +struct directory {
> + const char *value; /* Actual value or NULL if not known yet. */
This is really minor, but would you mind changing this to "not yet determined" from "not known yet"? Based on the comment, I was thinking this value was thinking that the value may not be knowable at this point.
> + const char *default_value; /* Default value. */
> + const char *var_name; /* Environment variable to override default. */
> +};
Otherwise, this looks good.
--Justin
More information about the dev
mailing list