[ovs-dev] [tests+nxm-ofctl 11/42] Convert stream and vconn interfaces to use ovs_be16, ovs_be32.

Justin Pettit jpettit at nicira.com
Thu Nov 25 01:57:31 UTC 2010


On Nov 23, 2010, at 2:43 PM, Ben Pfaff wrote:

> diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
> index a29a766..ddcbe36 100644
> --- a/lib/netdev-dummy.c
> +++ b/lib/netdev-dummy.c
> @@ -39,6 +39,7 @@ struct netdev_dev_dummy {
>     uint8_t hwaddr[ETH_ADDR_LEN];
>     int mtu;
>     struct netdev_stats stats;
> +    enum netdev_flags flags;
> };
> 
> struct netdev_dummy {
> @@ -90,6 +91,7 @@ netdev_dummy_create(const struct netdev_class *class, const char *name,
>     netdev_dev->hwaddr[4] = n >> 8;
>     netdev_dev->hwaddr[5] = n;
>     netdev_dev->mtu = 1500;
> +    netdev_dev->flags = 0;

I don't yet know how the dummy devices are going to be used, but you don't want to start them "up" and promiscuous?

The netdev-dummy changes seemed fine, but completely unrelated to the rest of this commit and the subject line.  The vconn and stream changes look good.

--Justin







More information about the dev mailing list