[ovs-dev] [tests+nxm-ofctl 11/42] Convert stream and vconn interfaces to use ovs_be16, ovs_be32.

Ben Pfaff blp at nicira.com
Mon Nov 29 21:51:15 UTC 2010


On Wed, Nov 24, 2010 at 05:57:31PM -0800, Justin Pettit wrote:
> On Nov 23, 2010, at 2:43 PM, Ben Pfaff wrote:
> 
> > diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
> > index a29a766..ddcbe36 100644
> > --- a/lib/netdev-dummy.c
> > +++ b/lib/netdev-dummy.c
> > @@ -39,6 +39,7 @@ struct netdev_dev_dummy {
> >     uint8_t hwaddr[ETH_ADDR_LEN];
> >     int mtu;
> >     struct netdev_stats stats;
> > +    enum netdev_flags flags;
> > };
> > 
> > struct netdev_dummy {
> > @@ -90,6 +91,7 @@ netdev_dummy_create(const struct netdev_class *class, const char *name,
> >     netdev_dev->hwaddr[4] = n >> 8;
> >     netdev_dev->hwaddr[5] = n;
> >     netdev_dev->mtu = 1500;
> > +    netdev_dev->flags = 0;
> 
> I don't yet know how the dummy devices are going to be used, but you
> don't want to start them "up" and promiscuous?

It doesn't really matter since they never (so far) actually receive any
packets anyway.

> The netdev-dummy changes seemed fine, but completely unrelated to the
> rest of this commit and the subject line.  

Oops, I meant to fold those into the patch that introduces the
netdev-dummy device.  I'll do that now.

> The vconn and stream changes look good.

Thanks.




More information about the dev mailing list