[ovs-dev] [PATCH 4/4] ovs: Implement 802.1ag Connectivity Fault Management

Ben Pfaff blp at nicira.com
Mon Nov 29 22:27:37 UTC 2010


On Mon, Nov 29, 2010 at 02:24:31PM -0800, Ethan Jackson wrote:
> > packets.h
> > ---------
> >
> > Does "struct ccm" really need to be packed?  At a glance it looks
> > properly aligned to me.
> 
> The build assertion fails on my system without the packed attribute.

OK, that's a good enough reason.

> I think it's good anyways because it documents that we are intending
> to send it on the wire.

By itself that's not good enough because working with packed structures
is slow on RISC systems, because it forces them to work with misaligned
data.

Thanks,

Ben.




More information about the dev mailing list