[ovs-dev] [overload 4/7] ofproto: Drop unneeded poll_immediate_wake().

Ben Pfaff blp at nicira.com
Fri Oct 1 00:17:38 UTC 2010


This poll_immediate_wake() is unnecessary because netflow_run() is always
called afterward within the same poll loop.  It's better to delete it, to
avoid wasting CPU.
---
 ofproto/ofproto.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index b8f7580..52f3ee7 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -4283,10 +4283,6 @@ rule_active_timeout(struct ofproto *ofproto, struct rule *rule)
         expired.used = rule->used;
 
         netflow_expire(ofproto->netflow, &rule->nf_flow, &expired);
-
-        /* Schedule us to send the accumulated records once we have
-         * collected all of them. */
-        poll_immediate_wake();
     }
 }
 
-- 
1.7.1





More information about the dev mailing list