[ovs-dev] [PATCH 1/3] ovs-ofctl: Add "queue-stats" command to print queue stats.

[Ben Pfaff]

Thank you for the review.

On Wed, Sep 29, 2010 at 10:26:53PM -0700, Justin Pettit wrote:
> On Sep 16, 2010, at 3:42 PM, Ben Pfaff wrote:
> In ofp_queue_stats_request, it's printed as "port_no", but in
> ofp_queue_stats_reply it is just "port".  I think it would be better
> to be consistent and preferably match the man page.  The same is true
> for "queue_id" and "queue".

OK, I changed these to "port" and "queue" in ofp-print.

>  (I'll also point out that the other patch series I reviewed today
>  used "port-name" and "queue-id" in ovs-controller).

port-name is a port name.  port_no is a port number, although a few
special port numbers (e.g. LOCAL) are spelled out.

In general I think that manpages should tend toward more verbosity,
because they are trying to explain a concept, and ofp-print should tend
toward more terseness, because you want your debug output to be short if
it can be.

> > +.IP "\fBqueue\-stats \fIswitch \fR[\fIport \fR[\fIqueue\fR]]"
> > +Prints to the console statistics for the specified \fIqueue\fR on
> > +\fIport\fR within \fIswitch\fR.  Either of \fIport\fR or \fIqueue\fR
> > +or both may be omitted (or equivalently specified as \fBALL\fR).  If
> 
> This seems to imply that "port" can be not specified and "queue" can
> be, which I don't think is true.

It is true.  I tested it.  When you have the same queues configured on
all your physical ports, it can be useful to find out stats on a given
queue across all the ports.