[ovs-dev] [overload 4/7] ofproto: Drop unneeded poll_immediate_wake().
Justin Pettit
jpettit at nicira.com
Thu Oct 7 06:53:58 UTC 2010
Looks good.
--Justin
On Sep 30, 2010, at 5:17 PM, Ben Pfaff wrote:
> This poll_immediate_wake() is unnecessary because netflow_run() is always
> called afterward within the same poll loop. It's better to delete it, to
> avoid wasting CPU.
> ---
> ofproto/ofproto.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index b8f7580..52f3ee7 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -4283,10 +4283,6 @@ rule_active_timeout(struct ofproto *ofproto, struct rule *rule)
> expired.used = rule->used;
>
> netflow_expire(ofproto->netflow, &rule->nf_flow, &expired);
> -
> - /* Schedule us to send the accumulated records once we have
> - * collected all of them. */
> - poll_immediate_wake();
> }
> }
>
> --
> 1.7.1
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
More information about the dev
mailing list