[ovs-dev] [PATCH] tunneling: Internal dev vport can be NULL.

[Jesse Gross]

On Fri, Oct 8, 2010 at 3:37 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Oct 05, 2010 at 07:19:19PM -0700, Jesse Gross wrote:
>> Commit 4bee42 "tunnel: Correctly check for internal device." fixed
>> the call to internal_dev_get_vport() by first checking that the
>> device is in fact an internal device.  However, it also accidentally
>> removed the check ensuring that the vport itself was not NULL.  This
>> adds that check back by redoing the previous change in a more robust
>> manner.
>>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> It seems a little sloppy to have internal_dev_get_vport() call
> is_internal_dev().  Some of its callers already do that.  But I can't
> see that it really matters, and I agree that this fixes a problem.
>

It is a little redundant in some places.  However, the caller that
needs this is the only one on a fast path and the check is required
there so I don't think it matters and it makes things a little more
robust to do it centrally.

> Acked-by: Ben Pfaff <blp at nicira.com>
>

Thanks, I pushed it out.