[ovs-dev] [PATCH 2/2] datapath: Fix build break in compat_query_flows().

Jesse Gross jesse at nicira.com
Mon Oct 11 21:14:15 UTC 2010


Both look fine, thanks.

Acked-by: Jesse Gross <jesse at nicira.com>

On Mon, Oct 11, 2010 at 2:07 PM, Ben Pfaff <blp at nicira.com> wrote:
> Commit a01ef04ce "datapath: Drop padding from struct odp_flow_key" removed
> the "reserved" member from struct odp_flow_key but overlooked uses of that
> member from 64-bit compatibility code.  This commit fixes up the problem.
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  datapath/datapath.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index eddc4ab..765b1eb 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -1847,7 +1847,6 @@ static int compat_query_flows(struct datapath *dp, struct compat_odp_flow *flows
>
>                if (compat_get_flow(&uf, ufp))
>                        return -EFAULT;
> -               memset(uf.key.reserved, 0, sizeof uf.key.reserved);
>
>                flow_node = tbl_lookup(table, &uf.key, flow_hash(&uf.key), flow_cmp);
>                if (!flow_node)
> --
> 1.7.1
>
>




More information about the dev mailing list