[ovs-dev] [PATCH] ofproto: Fix implementation of OFPP_FLOOD.

[Ben Pfaff]

Thanks, I pushed this out.

On Wed, Oct 13, 2010 at 05:14:16PM -0700, Ethan Jackson wrote:
> Looks Good
> 
> On Wed, Oct 13, 2010 at 17:12, Ben Pfaff <blp at nicira.com> wrote:
> > Commit f1588b1fa1 "datapath: Remove implementation of port groups" removed
> > a "break" statement accidentally, which caused OFPP_FLOOD to send duplicate
> > packets and to ignore OFPPC_NO_FLOOD.
> > ---
> >  ofproto/ofproto.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> > index e25ce28..5e99fca 100644
> > --- a/ofproto/ofproto.c
> > +++ b/ofproto/ofproto.c
> > @@ -2577,6 +2577,7 @@ xlate_output_action__(struct action_xlate_ctx *ctx,
> >     case OFPP_FLOOD:
> >         flood_packets(ctx->ofproto, ctx->flow.in_port, OFPPC_NO_FLOOD,
> >                       &ctx->nf_output_iface, ctx->out);
> > +        break;
> >     case OFPP_ALL:
> >         flood_packets(ctx->ofproto, ctx->flow.in_port, 0,
> >                       &ctx->nf_output_iface, ctx->out);
> > --
> > 1.7.1
> >
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
> >