[ovs-dev] [PATCH] lib: Fix warnings

[Ben Pfaff]

Seems more likely that we have different OpenSSL.

Here's what I see when I run "grep -E 'TLSv1_method|SSL_CTX_new'
/usr/include/openssl/*":

/usr/include/openssl/ssl.h:SSL_CTX *SSL_CTX_new(SSL_METHOD *meth);
/usr/include/openssl/ssl.h:SSL_METHOD *TLSv1_method(void);		/* TLSv1.0 */
/usr/include/openssl/ssl.h:SSL_METHOD *DTLSv1_method(void);		/* DTLSv1.0 */

Does yours have "const" somewhere in there?

On Thu, Oct 14, 2010 at 02:54:00PM -0700, Ethan Jackson wrote:
> Interesting . . .  Our compilers must be fighting.
> 
> No big deal I'll just ditch this patch.
> 
> Ethan
> On Thu, Oct 14, 2010 at 2:48 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Thu, Oct 14, 2010 at 02:40:11PM -0700, Ben Pfaff wrote:
> >> On Thu, Oct 14, 2010 at 02:31:31PM -0700, Ethan Jackson wrote:
> >> > Fixed a couple of warnings which showed up when compiling with
> >> > gcc-4.5.1
> >>
> >> Would you mind quoting the warnings that were fixed?  It really isn't
> >> obvious to me (I mostly use GCC 4.4 at the moment).
> >
> > Actually with this commit applied I get new warnings:
> >
> >    ../lib/stream-ssl.c: In function ‘do_ssl_init’:
> >    ../lib/stream-ssl.c:997: warning: passing argument 1 of ‘SSL_CTX_new’ discards qualifiers from pointer target type
> >    /usr/include/openssl/ssl.h:1344: note: expected ‘struct SSL_METHOD *’ but argument is of type ‘const struct SSL_METHOD *’
> >
> >