[ovs-dev] [netlink v2 4/4] datapath: Make adding and attaching a vport a single step.

[Ben Pfaff]

On Fri, Oct 15, 2010 at 03:06:56PM -0700, Jesse Gross wrote:
> On Wed, Oct 6, 2010 at 4:34 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Wed, Sep 29, 2010 at 05:35:24PM -0700, Jesse Gross wrote:
> >> Does this break "internal"/non-vport devices (if we had others)?  They
> >> won't get caught by the "system" type and it won't find a vport class
> >> type.
> >
> > Argh, yes.
> >
> > I've added "internal" to the list at the bottom of the file.
> >
> > This doesn't seem to be a very good way to do things.  Seems
> > conceptually wrong somehow.
> 
> I agree, it doesn't belong in here.  This is part of the reason why I
> don't want a vport parse config function that the Linux dpif directly
> calls: it forces everything into the vport netdev, even if it doesn't
> really need to be there.  If, instead, the dpif could just grab a
> parsed config from the netdev (through a Linux dpif specific
> interface) then we could keep the "internal" netdev (and "system" as
> well) out of the "vport" netdev.  I think that would address all of my
> remaining comments.

Yes, that's what I'm planning to do--just haven't had time yet.