[ovs-dev] [PATCH 1/2] datapath: #define local_bh_disable to preempt_disable on RT.
Ben Pfaff
blp at nicira.com
Mon Oct 25 16:22:14 UTC 2010
On Fri, Oct 22, 2010 at 04:34:13PM -0700, Jesse Gross wrote:
> We use local_bh_disable() to mean that we don't want to get
> preempted or interrupted and normally it covers both situations.
> However, on RT kernels local_bh_disable() becomes a no-op because
> bottom halves aren't interrupts any more. We still want the
> behavior of disabling preemption so #define them to be the same
> on these kernels.
This will fix the problem, of course. But most of the code in
compat-2.6 improves compatibility with older kernels. This introduces
code into the compat-2.6 directory that has a different purpose, without
giving the reader an obvious hint why it is there.
So I'd at least like a comment. Pending that, here's my
Acked-by: Ben Pfaff <blp at nicira.com>
Thanks,
Ben.
More information about the dev
mailing list