[ovs-dev] [nxm 11/42] odp-util: Print tunnel id as part of ODP flow key in format_odp_flow_key().

[Ben Pfaff]

On Thu, Oct 28, 2010 at 03:56:43PM -0700, Justin Pettit wrote:
> On Oct 28, 2010, at 10:27 AM, Ben Pfaff wrote:
> 
> > @@ -42,7 +42,7 @@ odp_actions_add(struct odp_actions *actions, uint16_t type)
> > void
> > format_odp_flow_key(struct ds *ds, const struct odp_flow_key *key)
> > {
> > -    ds_put_format(ds, "in_port%04x tci(", key->in_port);
> > +    ds_put_format(ds, "tun_id%08x in_port%04x tci(", key->tun_id, key->in_port);
> 
> Is there a reason we print the port in hex?  (I know this isn't new
> with this patch.)  This has been mentioned before as confusing, since
> the port associated with an output action is in decimal.

I don't remember.  I've changed it to decimal now, by adding another
commit after this one.

> Tunnel id is at least consistent between the flow definition and the
> set_tunnel action.  However, the action is prepended with "0x", so it
> may be nice to print them in a similar manner.

OK, I added 0x here too.