[ovs-dev] [PATCH 2/2] Properly print drop_spoofed_arp actions when decoding OpenFlow and ODP.

Justin Pettit jpettit at nicira.com
Wed Sep 15 20:20:32 UTC 2010


The set looks good to me.

--Justin


On Sep 15, 2010, at 12:55 PM, Ben Pfaff wrote:

> Also fix formatting of unknown Nicira actions in OpenFlow.
> ---
> lib/odp-util.c  |    3 +++
> lib/ofp-print.c |    6 +++++-
> 2 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 442c939..798e425 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
> @@ -95,6 +95,9 @@ format_odp_action(struct ds *ds, const union odp_action *a)
>     case ODPAT_POP_PRIORITY:
>         ds_put_cstr(ds, "pop_priority");
>         break;
> +    case ODPAT_DROP_SPOOFED_ARP:
> +        ds_put_cstr(ds, "drop_spoofed_arp");
> +        break;
>     default:
>         ds_put_format(ds, "***bad action 0x%"PRIx16"***", a->type);
>         break;
> diff --git a/lib/ofp-print.c b/lib/ofp-print.c
> index 8704878..78f3649 100644
> --- a/lib/ofp-print.c
> +++ b/lib/ofp-print.c
> @@ -200,8 +200,12 @@ ofp_print_nx_action(struct ds *string, const struct nx_action_header *nah)
>         break;
>     }
> 
> +    case NXAST_DROP_SPOOFED_ARP:
> +        ds_put_cstr(string, "drop_spoofed_arp");
> +        break;
> +
>     default:
> -        ds_put_format(string, "***unknown Nicira action:%d***\n",
> +        ds_put_format(string, "***unknown Nicira action:%d***",
>                       ntohs(nah->subtype));
>     }
> }
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org





More information about the dev mailing list