[ovs-dev] [PATCH 1/2] debian: Init script should put core dumps in an appropriate place

[Ben Pfaff]

On Tue, Sep 14, 2010 at 08:15:28PM -0700, Ethan Jackson wrote:
> From: Ethan Jackson <ejj at ej2.org>

You should probably use your @nicira.com address for commits.

You should add yourself to AUTHORS as part of your first commit.

Looks good, one other comment:

> @@ -245,6 +249,7 @@ case "$1" in
>          echo -n "Starting ovsdb-server: "
>          start-stop-daemon --start --quiet \
>              --pidfile /var/run/openvswitch/ovsdb-server.pid \
> +            -d /var/log/openvswitch/cores                   \
>              --exec $ovsdb_server -- "$@"
>          if running ovsdb-server; then
>              echo "ovsdb-server."
> @@ -258,12 +263,13 @@ case "$1" in

The rest of the options to start-stop-daemon use the long form, so let's
use --chdir instead of -d for consistency.  Ditto in the other three
places in the script.

Thanks Ethan, welcome to the repository.