[ovs-dev] [PATCH 2/2] debian: Created a debian equivalent to xen-bugtool

[Ben Pfaff]

Thanks Ethan!  This was throwing you in deeper than I expected, since it
highlights a lot of the differences between RH/Centos/XenServer and
Debian.

On Tue, Sep 14, 2010 at 08:15:29PM -0700, Ethan Jackson wrote:
> From: Ethan Jackson <ejj at ej2.org>

Same comment about email address as 1/2.

> +# You should have received a copy of the GNU Lesser General Public
> +# License along with this library; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> +#
> +# Copyright (c) 2005, 2007, 2010 XenSource Ltd.

We should probably add a copyright 2010 line for Nicira now.

Did you check that programs, files, and directories are in the same
place in Debian?  Occasionally Red Hat and Debian differ in placement.

Some of the bits at the top popped out as being specific to XenServer or
not relevant to Debian installs and seem worth removing:

        EXTLINUX_CONFIG
        LVM_CACHE
        PROC_NET_BONDING_DIR
        PROC_NET_VLAN_DIR
        PROC_DRIVER_CCISS_DI
        MULTIPATH_CONF
        HOST_CRASHDUMPS_DIR
        HOST_CRASHDUMP_LOGS_RE
        PATCH_APPLIED_DIR
        FIST_RE
        LICENSE_LOGS
        LWIDENTITY_JOIN_LOG
        HOSTS_LWIDENTITY_ORIG
        KRB5_CONF
        LIKEWISE_DIR

There's no point in listing bridges, in the loop that contains:
        if os.path.isdir('/sys/class/net/%s/bridge' % p):

Some of the log files in the list that starts out 'crit.log' are not
mentioned in /etc/syslog.conf on my Debian box.  You should probably
revise the list.

There is at least one reference to Xen in user messages that we should
change to refer to Linux or to Open vSwitch.

This doesn't appear to install the new program anywhere.  It should
probably put it into openvswitch-common.  It needs to at least add the
file to the list in debian/automake.mk or "make dist" will report an
error.

Debian doesn't have chkconfig.

The tapdisk stuff shouldn't be relevant.

When we add this to the Debian packaging we should also make sure to add
proper dependencies; for example, the script uses bzip2 so that should
be a dependency.  If there are lots of these dependencies then we'll
have to drop some of them (i.e. hdparm or lvdisplay would probably be no
great loss) or break this program into a separate openvswitch-bugtool
package.

Oh and of course we need a dependency on Python and on the Debian
packaging for any Python module not part of the standard Python library
(but on a quick scan all of the modules it uses look pretty standard).

Thanks again.