[ovs-dev] [PATCH 3/7] datapath: Enable usage of cached flows.

Ben Pfaff blp at nicira.com
Mon Sep 20 20:20:10 UTC 2010


On Mon, Sep 20, 2010 at 11:13:41AM -0700, Jesse Gross wrote:
> An upcoming commit will add support for supplying cached flows for
> packets entering the datapath.  This adds the code in the datapath
> itself to recognize these cached flows and use them instead of
> extracting the flow fields and doing a lookup.

This is clever: I expected that we would have to allocate the flow key
separately or embed it into struct ovs_skb_cb, but it doesn't have to do
that.  Great.

It looks OK to me.

One corner case I do not see handled is where the cached flow is an IPv4
fragment and fragment dropping is enabled.  This would only happen if
the first datapath hit by a packet had fragment dropping disabled and a
later one had fragment dropping enabled, so it may not be an interesting
case.

Thanks,

Ben.




More information about the dev mailing list