[ovs-dev] [PATCH 3/4] vswitch: Disable header-caching when IPsec is enabled
Ben Pfaff
blp at nicira.com
Thu Sep 23 23:42:37 UTC 2010
On Thu, Sep 23, 2010 at 04:34:44PM -0700, Justin Pettit wrote:
> Header caching speeds up sending tunneled traffic by bypassing the Linux
> IP stack. This also causes it to bypass IPsec processing, which will
> break connectivity. This commit disables header caching when IPsec is
> enabled.
I assume that Jesse will want to review this, but:
> + /* Include "other_config" keys in hash of netdev options. The
> + * namespace of "other_config" and "options" must be disjoint.
> + * Prefer "options" keys over "other_config" keys. */
> + for (i = 0; i < iface_cfg->n_other_config; i++) {
> + if (!shash_add_once(&options, iface_cfg->key_other_config[i],
> + xstrdup(iface_cfg->value_other_config[i]))) {
> + VLOG_WARN("%s: 'other_config' key %s conflicts with existing "
> + "'other_config' or 'options' entry...ignoring",
> + iface_cfg->name, iface_cfg->key_other_config[i]);
> + }
> + }
> +
this leaks the "value" string each time it logs a message. Also
elsewhere we use "quotes" for quoting in messages instead of
'apostrophes'.
Thanks,
Ben.
More information about the dev
mailing list