[ovs-dev] [PATCH 3/4] vswitch: Disable header-caching when IPsec is enabled

Jesse Gross jesse at nicira.com
Fri Sep 24 00:00:15 UTC 2010


On Thu, Sep 23, 2010 at 4:34 PM, Justin Pettit <jpettit at nicira.com> wrote:
> +    /* IPsec doesn't work when header caching is enabled.  Disable it if
> +     * the IPsec local IP address and authentication mechanism have been
> +     * defined. */
> +    if (ipsec_ip_set && ipsec_mech_set) {
> +        config->flags &= ~TNL_F_HDR_CACHE;
> +    }

We should log a message if header caching is explicitly enabled and
this disables it.  Actually I wonder if we should always log a message
since this potentially causes different behavior in ways that do not
directly relate to IPsec.

> +    /* Include "other_config" keys in hash of netdev options.  The
> +     * namespace of "other_config" and "options" must be disjoint.
> +     * Prefer "options" keys over "other_config" keys. */
> +    for (i = 0; i < iface_cfg->n_other_config; i++) {
> +        if (!shash_add_once(&options, iface_cfg->key_other_config[i],
> +                            xstrdup(iface_cfg->value_other_config[i]))) {
> +            VLOG_WARN("%s: 'other_config' key %s conflicts with existing "
> +                      "'other_config' or 'options' entry...ignoring",
> +                      iface_cfg->name, iface_cfg->key_other_config[i]);
> +        }
> +    }

I still think the use of other_config here is lame.




More information about the dev mailing list